Change references to section back to template part #23765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahtallen
added
[Type] Enhancement
noahtallen
requested review from
ajitbohra,
nerrad,
ntwb,
Soean and
talldan
as code owners
|
Size Change: -9 B (0%) Total Size: 1.14 MB
ℹ️ View Unchanged
|
Addison-Stavlo
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
This looks like it covers everything #23295 changed regarding the naming, and it tests well. Maybe @epiqueras knows of any other changes that original PR may have missed, otherwise this seems pretty comprehensive.
Thanks for updating this one @noahtallen !
ZebulanStanphill
approved these changes
Jul 7, 2020
|
Nice! I'll keep an eye out for more references as we go :) |
|
This looks like everything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This resolves #23657, changing the "section" block back to "template part". I mostly followed #23295 to see which files had been change to use "section". Let me know if there are further changes to make; this is everything I could find so far!
How has this been tested?
Locally, in edit site. Additionally, e2e tests have been updated and should pass.
Screenshots
Types of changes
Rename a term.
Checklist: